rusackas commented on code in PR #40821: URL: https://github.com/apache/superset/pull/40821#discussion_r3366138391
########## superset-frontend/playwright/tests/dashboard/gauge-interval-colors.spec.ts: ########## @@ -0,0 +1,195 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/** + * Regression for #28766: a Gauge chart configured with interval bounds and + * interval colors (mapped to a categorical color scheme) sometimes renders the + * wrong interval colors when first loaded on a dashboard — a refresh fixes it. + * + * The gauge renders to a <canvas>, so this test reads pixels back from the + * rendered gauge and asserts the configured interval colors are present in the + * correct mapping. With `color_scheme: supersetColors` and + * `interval_color_indices: '1,2'`, the gauge axis must paint the scheme's 1st + * and 2nd colors (#1FA8C9 and #454E7C) and must NOT paint the 3rd (#5AC189), + * which would indicate a shifted / fallback palette. + * + * CI green => the gauge paints the configured interval colors on first load; + * merging closes #28766 and guards against regressions. + * CI red => the interval colors are wrong on first load; the bug is live in + * plugin-chart-echarts/src/Gauge (color-scheme resolution). + */ +import { testWithAssets, expect } from '../../helpers/fixtures'; +import { apiPost, apiPut } from '../../helpers/api/requests'; +import { apiPostDashboard } from '../../helpers/api/dashboard'; +import { DashboardPage } from '../../pages/DashboardPage'; + +const DATASET_NAME = 'birth_names'; + +// supersetColors palette: index 1 = #1FA8C9, index 2 = #454E7C, index 3 = #5AC189 +const COLOR_INTERVAL_1: [number, number, number] = [31, 168, 201]; +const COLOR_INTERVAL_2: [number, number, number] = [69, 78, 124]; +const COLOR_UNUSED_3: [number, number, number] = [90, 193, 137]; + +async function findDatasetIdByName(page: any, name: string): Promise<number> { + const query = `(filters:!((col:table_name,opr:eq,value:'${name}')))`; + const resp = await page.request.get(`api/v1/dataset/?q=${query}`); + const body = await resp.json(); Review Comment: Good catch — fixed in af354e7. The dataset lookup now uses the existing `getDatasetByName` helper from `helpers/api/dataset.ts`, which routes through `apiGet`/`withTransientRetry`, so it gets the same transient-network retry behavior as the rest of the suite. ########## superset-frontend/playwright/tests/dashboard/gauge-interval-colors.spec.ts: ########## @@ -0,0 +1,195 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/** + * Regression for #28766: a Gauge chart configured with interval bounds and + * interval colors (mapped to a categorical color scheme) sometimes renders the + * wrong interval colors when first loaded on a dashboard — a refresh fixes it. + * + * The gauge renders to a <canvas>, so this test reads pixels back from the + * rendered gauge and asserts the configured interval colors are present in the + * correct mapping. With `color_scheme: supersetColors` and + * `interval_color_indices: '1,2'`, the gauge axis must paint the scheme's 1st + * and 2nd colors (#1FA8C9 and #454E7C) and must NOT paint the 3rd (#5AC189), + * which would indicate a shifted / fallback palette. + * + * CI green => the gauge paints the configured interval colors on first load; + * merging closes #28766 and guards against regressions. + * CI red => the interval colors are wrong on first load; the bug is live in + * plugin-chart-echarts/src/Gauge (color-scheme resolution). + */ +import { testWithAssets, expect } from '../../helpers/fixtures'; +import { apiPost, apiPut } from '../../helpers/api/requests'; +import { apiPostDashboard } from '../../helpers/api/dashboard'; +import { DashboardPage } from '../../pages/DashboardPage'; + +const DATASET_NAME = 'birth_names'; + +// supersetColors palette: index 1 = #1FA8C9, index 2 = #454E7C, index 3 = #5AC189 +const COLOR_INTERVAL_1: [number, number, number] = [31, 168, 201]; +const COLOR_INTERVAL_2: [number, number, number] = [69, 78, 124]; +const COLOR_UNUSED_3: [number, number, number] = [90, 193, 137]; + +async function findDatasetIdByName(page: any, name: string): Promise<number> { + const query = `(filters:!((col:table_name,opr:eq,value:'${name}')))`; + const resp = await page.request.get(`api/v1/dataset/?q=${query}`); + const body = await resp.json(); + if (!body.result?.length) { + throw new Error(`Dataset ${name} not found`); + } + return body.result[0].id; +} + +testWithAssets( + 'Gauge renders configured interval colors on a dashboard (#28766)', + async ({ page, testAssets }) => { + const datasetId = await findDatasetIdByName(page, DATASET_NAME); + + const chartParams = { + datasource: `${datasetId}__table`, + viz_type: 'gauge_chart', + metric: 'count', + adhoc_filters: [], + groupby: [], + row_limit: 10, + color_scheme: 'supersetColors', + min_val: 0, + max_val: 100, + start_angle: 225, + end_angle: -45, + intervals: '50,100', + interval_color_indices: '1,2', + show_pointer: true, + number_format: 'SMART_NUMBER', + value_formatter: '{value}', + }; + const chartResp = await apiPost(page, 'api/v1/chart/', { + slice_name: `gauge_interval_colors_${Date.now()}`, + viz_type: 'gauge_chart', + datasource_id: datasetId, + datasource_type: 'table', + params: JSON.stringify(chartParams), + }); + expect(chartResp.ok()).toBe(true); + const chartId: number = (await chartResp.json()).id; + testAssets.trackChart(chartId); Review Comment: Agreed — fixed in af354e7. Chart creation now goes through the `apiPostChart` helper and the response is normalized as `body.result?.id ?? body.id`, throwing immediately if no id is returned instead of silently propagating `undefined`. ########## superset-frontend/playwright/tests/dashboard/gauge-interval-colors.spec.ts: ########## @@ -0,0 +1,195 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/** + * Regression for #28766: a Gauge chart configured with interval bounds and + * interval colors (mapped to a categorical color scheme) sometimes renders the + * wrong interval colors when first loaded on a dashboard — a refresh fixes it. + * + * The gauge renders to a <canvas>, so this test reads pixels back from the + * rendered gauge and asserts the configured interval colors are present in the + * correct mapping. With `color_scheme: supersetColors` and + * `interval_color_indices: '1,2'`, the gauge axis must paint the scheme's 1st + * and 2nd colors (#1FA8C9 and #454E7C) and must NOT paint the 3rd (#5AC189), + * which would indicate a shifted / fallback palette. + * + * CI green => the gauge paints the configured interval colors on first load; + * merging closes #28766 and guards against regressions. + * CI red => the interval colors are wrong on first load; the bug is live in + * plugin-chart-echarts/src/Gauge (color-scheme resolution). + */ +import { testWithAssets, expect } from '../../helpers/fixtures'; +import { apiPost, apiPut } from '../../helpers/api/requests'; +import { apiPostDashboard } from '../../helpers/api/dashboard'; +import { DashboardPage } from '../../pages/DashboardPage'; + +const DATASET_NAME = 'birth_names'; + +// supersetColors palette: index 1 = #1FA8C9, index 2 = #454E7C, index 3 = #5AC189 +const COLOR_INTERVAL_1: [number, number, number] = [31, 168, 201]; +const COLOR_INTERVAL_2: [number, number, number] = [69, 78, 124]; +const COLOR_UNUSED_3: [number, number, number] = [90, 193, 137]; + +async function findDatasetIdByName(page: any, name: string): Promise<number> { + const query = `(filters:!((col:table_name,opr:eq,value:'${name}')))`; + const resp = await page.request.get(`api/v1/dataset/?q=${query}`); + const body = await resp.json(); + if (!body.result?.length) { + throw new Error(`Dataset ${name} not found`); + } + return body.result[0].id; +} Review Comment: Addressed in af354e7. Rather than add a new `helpers/dataset.ts` (which would duplicate the existing `getDatasetByName` in `helpers/api/dataset.ts`), I removed the local `findDatasetIdByName` here and reuse that shared helper, which already centralizes the dataset API lookup with retry handling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
