bito-code-review[bot] commented on code in PR #40833: URL: https://github.com/apache/superset/pull/40833#discussion_r3368069581
########## superset-frontend/src/utils/navigationUtils.test.ts: ########## @@ -0,0 +1,33 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { navigateTo } from './navigationUtils'; + +test('navigateTo with assign: true ignores repeated calls to the same URL', () => { + const assignSpy = jest.fn(); + Object.defineProperty(window, 'location', { + configurable: true, + value: { assign: assignSpy, href: '' }, + }); + + navigateTo('/dashboard/new', { assign: true }); + navigateTo('/dashboard/new', { assign: true }); + + expect(assignSpy).toHaveBeenCalledTimes(1); + expect(assignSpy).toHaveBeenCalledWith('/dashboard/new'); +}); Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Module state pollution in tests</b></div> <div id="fix"> The test relies on `pendingAssignUrl` in `navigationUtils` being `null` at start, but this module-level variable persists across test files. If another test in the same process calls `navigateTo(..., { assign: true })` before this test, the first assertion will fail because `pendingAssignUrl` is already set to a value. Additionally, `ensureAppRoot` is not mocked — in production deployments with `SUPERSET_APP_ROOT=/superset`, the URL would be transformed to `/superset/dashboard/new`, causing a mismatch with the expected value. </div> </div> <small><i>Code Review Run #764792</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
