Copilot commented on code in PR #40833:
URL: https://github.com/apache/superset/pull/40833#discussion_r3383169169
##########
superset-frontend/src/utils/navigationUtils.ts:
##########
@@ -30,7 +32,10 @@ export const navigateTo = (
'noopener noreferrer',
);
} else if (options?.assign) {
- window.location.assign(sanitizeUrl(ensureAppRoot(url)));
+ const sanitized = sanitizeUrl(ensureAppRoot(url));
+ if (pendingAssignUrl === sanitized) return;
+ pendingAssignUrl = sanitized;
+ window.location.assign(sanitized);
Review Comment:
The module-level `pendingAssignUrl` never resets unless the page is fully
reloaded. In browsers that restore the page from the back/forward cache
(bfcache), module state is preserved, so returning to the dashboards list via
Back can leave `pendingAssignUrl` set and make subsequent clicks to the same
`assign` URL a no-op (preventing users from creating another dashboard/chart).
Consider deduping only within a short time window (sufficient for double-click
protection) instead of for the entire page lifetime.
##########
superset-frontend/src/utils/navigationUtils.test.ts:
##########
@@ -0,0 +1,33 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { navigateTo } from './navigationUtils';
+
+test('navigateTo with assign: true ignores repeated calls to the same URL', ()
=> {
+ const assignSpy = jest.fn();
+ Object.defineProperty(window, 'location', {
+ configurable: true,
+ value: { assign: assignSpy, href: '' },
+ });
+
+ navigateTo('/dashboard/new', { assign: true });
+ navigateTo('/dashboard/new', { assign: true });
+
+ expect(assignSpy).toHaveBeenCalledTimes(1);
+ expect(assignSpy).toHaveBeenCalledWith('/dashboard/new');
+});
Review Comment:
This test replaces `window.location` via `Object.defineProperty`, which is
less consistent with existing test patterns in this repo and makes it easy to
forget restoration/partial Location fields. Elsewhere, tests typically use
`jest.spyOn(window, 'location', 'get').mockReturnValue(...)` and then
`mockRestore()` (e.g. `src/features/home/DashboardTable.test.tsx`). Updating to
that pattern makes the test less brittle and keeps `window.location` shape
intact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
