kwilt commented on PR #38227: URL: https://github.com/apache/superset/pull/38227#issuecomment-4651914755
> @kwilt Thanks for digging into this and sharing your findings This PR was intended to address the formatting-related cache key mismatches reported in the original issue (`\r\n` vs `\n`, whitespace differences, etc.). The transpilation-related divergence you found seems like a different source of cache-key instability. @villebro, what do you think? Should we extend this PR to handle the transpilation case as well, or would you prefer to keep this fix scoped to formatting normalization and address the remaining hash divergence in a follow-up PR? sqlglot (the underlying transpiler library used in my example) handles stripping all of the escape sequences, control characters, etc. https://sqlglot.com/sqlglot/executor.html#parsing "Once a SQL statement is tokenized, we don't need to worry about white space and other formatting, so it's easier to work with." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
