aminghadersohi commented on code in PR #40647:
URL: https://github.com/apache/superset/pull/40647#discussion_r3383303151
##########
tests/unit_tests/config_test.py:
##########
@@ -312,3 +312,13 @@ def test_full_setting(
assert dttm_col.is_dttm
assert dttm_col.python_date_format == "epoch_s"
assert dttm_col.expression == "CAST(dttm as INTEGER)"
+
+
+def test_smtp_ssl_server_auth_defaults_to_true() -> None:
+ """
+ The shipped default for SMTP_SSL_SERVER_AUTH validates the SMTP server's
+ TLS certificate. Operators can still opt out by overriding it to False.
+ """
+ from superset import config
+
+ assert config.SMTP_SSL_SERVER_AUTH is True
Review Comment:
NIT: asserts the module-level default but not the behavior. No test confirms
`ssl.create_default_context()` is called and its return value passed to
`SMTP_SSL`/`starttls` when `SMTP_SSL_SERVER_AUTH=True`. The integration test
for `test_send_mime_ssl` opts *out* of the new default (line 211) rather than
covering the enabled path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
