sadpandajoe commented on code in PR #40832:
URL: https://github.com/apache/superset/pull/40832#discussion_r3383894787
##########
superset-frontend/src/dashboard/components/Header/Header.test.tsx:
##########
@@ -522,9 +522,9 @@ test('should disable both buttons when no actions
available', () => {
expect(onRedo).not.toHaveBeenCalled();
});
-test('should render the "Discard changes" button', () => {
+test('should render the "Discard" button as disabled', () => {
Review Comment:
Do we have a test that validates when the disable button should be enabled?
If not we should add that as part of this PR to make sure nothing is broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
