rusackas commented on PR #40648: URL: https://github.com/apache/superset/pull/40648#issuecomment-4665357335
Lifting the hold — the test failures are resolved (rebased on master; the unit tests now cover that a non-owner *with* chart access, i.e. the report-worker / Explore-backfill case, still succeeds, while a non-owner without access is rejected). The remaining `hold:testing` concern was the report-execution flow; report workers run as the report owner, who has chart access, so the new `raise_for_access` is satisfied for them. Reviewers may still want to spot-check a report screenshot run, but the path is covered by tests. Marking ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
