rusackas commented on PR #40648: URL: https://github.com/apache/superset/pull/40648#issuecomment-4674001867
Opened the follow-up I promised for the `query_context.datasource` validation gap: #40953. Keeping that out of this PR's scope as discussed — this PR's chart-access gate stands on its own. Thanks again @richardfogaca for the thorough pass; all the actionable items (deterministic integration test, pinned unit assertion, positive non-owner-with-access test, and the nits) landed in d796fc3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
