bito-code-review[bot] commented on code in PR #40931:
URL: https://github.com/apache/superset/pull/40931#discussion_r3387266814
##########
superset-frontend/src/setup/setupFormatters.ts:
##########
@@ -29,6 +29,7 @@ import {
createSmartDateVerboseFormatter,
createSmartDateDetailedFormatter,
createMemoryFormatter,
+ setCurrencyLocale,
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing unit tests for new behavior</b></div>
<div id="fix">
The new `setCurrencyLocale(locale)` call at line 44 lacks unit test
coverage. The existing `preamble.test.ts` mocks `setupFormatters` entirely, so
it cannot verify this internal behavior. Add tests covering: (1)
`setCurrencyLocale` is called with the passed locale, (2) behavior when locale
is undefined/empty (should be ignored per `currencyLocale.ts` implementation).
</div>
</div>
<small><i>Code Review Run #fe0630</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
