dosubot[bot] commented on PR #40946: URL: https://github.com/apache/superset/pull/40946#issuecomment-4673758904
<!-- Answer --> Good catch. The current constraint in `pyproject.toml` is actually `>=2.4.0, <3.0` [[1]](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/pyproject.toml#L134), so this PR is proposing to change both bounds — raising the floor from 2.4 to 7.0 *and* raising the ceiling from 3.0 to 8.0. That's a significant jump. Widening the bracket to something like `>=2.4.0, <8.0` would be the safer approach — it allows users already on 2.x/3.x/6.x to continue working while also permitting the new 7.0 release. Since this is an optional extra (`pip install 'apache-superset[exasol]'`) and there's no indication that older versions are broken with Superset's engine spec [[2]](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset/db_engine_specs/exasol.py), there's no strong reason to force everyone to jump to 7.0+. That said, sqlalchemy-exasol 7.0 is a major release with breaking changes (DLT support, PEP-249 exception handling, binary type restrictions), so it might be worth checking whether Superset's Exasol engine spec still works cleanly with both old and new versions before merging any change here. <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=reply-with-mention&utm_term=apache%2Fsuperset).* --- Share context across your team and agents. Try [Dosu](https://dosu.dev?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=knowledge-infrastructure-tagline&utm_term=apache%2Fsuperset). [](https://app.dosu.dev/response-feedback?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=knowledge-infrastructure-feedback&utm_term=apache%2Fsuperset&message_id=c84aa27a-b16b-407d-be94-1b29f82daee6) [](https://github.dosu.com/apache/superset?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=knowledge-infrastructure-learn-repo&utm_term=apache%2Fsuperset) [](https://app.dosu.dev/signup?referrer=openSource&source=github-footer&utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=knowledge-infrastructure-add-team&utm_term=apache%2Fsuperset) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
