justinpark commented on code in PR #40680:
URL: https://github.com/apache/superset/pull/40680#discussion_r3391336480
##########
superset-frontend/src/components/GridTable/Header.tsx:
##########
@@ -37,11 +32,9 @@ interface Params {
displayName: string;
column: Column;
api: GridApi;
- setSort: (sort: string | null, multiSort: boolean) => void;
+ progressSort: (multiSort?: boolean) => void;
Review Comment:
The reported finding is incorrect. progressSort is a standard member of
ag-grid's IHeaderParams interface (line 55 of iHeader.d.ts) — it is injected by
ag-grid itself when it instantiates any custom header component, exactly the
same as column, api, displayName, and enableSorting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
