bito-code-review[bot] commented on code in PR #40680:
URL: https://github.com/apache/superset/pull/40680#discussion_r3391337515
##########
superset-frontend/src/components/GridTable/Header.tsx:
##########
@@ -37,11 +32,9 @@ interface Params {
displayName: string;
column: Column;
api: GridApi;
- setSort: (sort: string | null, multiSort: boolean) => void;
+ progressSort: (multiSort?: boolean) => void;
Review Comment:
<!-- Bito Reply -->
The reviewer's concern is based on the assumption that `progressSort` is a
custom prop that ag-grid does not automatically pass to custom header
components. If `progressSort` is indeed a standard member of the
`IHeaderParams` interface provided by ag-grid, then the wrapper is unnecessary,
as ag-grid will inject it automatically when it instantiates the component. You
should verify if `progressSort` is part of the `IHeaderParams` interface in
your project's version of ag-grid. If it is, you can safely ignore the
suggestion to add the wrapper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
