github-advanced-security[bot] commented on code in PR #39925:
URL: https://github.com/apache/superset/pull/39925#discussion_r3393518752
##########
superset-frontend/src/extensions/ExtensionsLoader.ts:
##########
@@ -107,10 +108,12 @@
private async loadModule(extension: Extension): Promise<void> {
const { remoteEntry, id } = extension;
- // Load the remote entry script
+ // Load the remote entry script. The backend emits a router-relative
+ // remoteEntry URL; `makeUrl` applies the application root for
+ // subdirectory deployments (idempotent, and absolute URLs pass through).
await new Promise<void>((resolve, reject) => {
const element = document.createElement('script');
- element.src = remoteEntry;
+ element.src = makeUrl(remoteEntry);
Review Comment:
## CodeQL / DOM text reinterpreted as HTML
[DOM text](1) is reinterpreted as HTML without escaping meta-characters.
[Show more
details](https://github.com/apache/superset/security/code-scanning/2542)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
