sadpandajoe commented on PR #39925: URL: https://github.com/apache/superset/pull/39925#issuecomment-4683150382
@eschutho Thanks, fixed some of your comments but left two out of this PR. Feel free to push back if we really want it. AllEntitiesTable Typography.Link - keeping the antd Typography.Link + ensureAppRoot pattern for now. As you noted the risk is low (backend URL, React strips javascript:), and a styling-preserving antd-aware <AppLink> wrapper is a new export I'd rather land in the follow-up so it can be applied consistently across all antd link sites. APPLICATION_ROOT_CALL_ALLOWLIST (FilterBar + useStreamingExport) — intentional deferred migration targets, not oversights; FilterBar's call is a genuine pathname-prefix check ensureAppRoot can't express. I'm happy to add it to this PR but it feels like the PR is getting quite large and complex now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
