bito-code-review[bot] commented on code in PR #40963:
URL: https://github.com/apache/superset/pull/40963#discussion_r3394088610
##########
superset/sql/parse.py:
##########
@@ -864,7 +868,7 @@ def check_functions_present(self, functions: set[str]) ->
bool:
else:
present.add(function.name.upper())
- return any(function.upper() in present for function in functions)
+ return present
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing unit tests for new method</b></div>
<div id="fix">
The new public method `get_present_functions()` has no direct unit tests.
Only indirect coverage exists via `check_functions_present` tests. Per BITO.md
rule [11730], new tools should have dedicated unit tests covering success
paths, error scenarios, and edge cases.
</div>
</div>
<small><i>Code Review Run #1be33c</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
