codeant-ai-for-open-source[bot] commented on code in PR #40963:
URL: https://github.com/apache/superset/pull/40963#discussion_r3428307539
##########
superset/sql/parse.py:
##########
@@ -1419,15 +1423,9 @@ def optimize(self) -> KustoKQLStatement:
"""
return KustoKQLStatement(ast=self._parsed, engine=self.engine)
- def check_functions_present(self, functions: set[str]) -> bool:
- """
- Check if any of the given functions are present in the script.
-
- :param functions: List of functions to check for
- :return: True if any of the functions are present
- """
+ def get_present_functions(self) -> set[str]:
logger.warning("Kusto KQL doesn't support checking for functions
present.")
- return False
+ return set()
Review Comment:
**Suggestion:** Add a method docstring explaining the behavior and return
value of this newly introduced function to keep new Python code documented
inline. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is a newly added Python method and it does not include a docstring. The
custom rule requires new functions and classes to be documented inline, so the
suggestion correctly identifies a real violation.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=6f951976bf4b44e498fd15c0063d72a2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=6f951976bf4b44e498fd15c0063d72a2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/sql/parse.py
**Line:** 1426:1428
**Comment:**
*Custom Rule: Add a method docstring explaining the behavior and return
value of this newly introduced function to keep new Python code documented
inline.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40963&comment_hash=b9b32c241546ed03538f1cff00ca49aae658eca9891c98a44a57e704ebffa892&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40963&comment_hash=b9b32c241546ed03538f1cff00ca49aae658eca9891c98a44a57e704ebffa892&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
