bito-code-review[bot] commented on code in PR #40129:
URL: https://github.com/apache/superset/pull/40129#discussion_r3399241865
##########
superset/translations/th/LC_MESSAGES/messages.po:
##########
@@ -5236,6 +5236,9 @@ msgstr "ไม่สามารถสร้างแผนภูมิได้
# de, es, fa, fr, it, ja, ko, lv, mi, nl, pl, pt, pt_BR, ru, sk, sl, tr, uk,
# zh, zh_TW]
#, fuzzy
+msgid "Chart could not be restored."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Thai translation</b></div>
<div id="fix">
The `msgstr` is empty for this translation entry. Thai users will see
untranslated English text 'Chart could not be restored.' when
`ChartRestoreFailedError` is raised. Compare with similar entries: 'Chart could
not be created.' → 'ไม่สามารถสร้างแผนภูมิได้' and 'Chart could not be updated.'
→ 'ไม่สามารถอัปเดตแผนภูมิได้'. The missing translation should follow the same
pattern.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- superset/translations/th/LC_MESSAGES/messages.po (lines 5238-5240)
+++ superset/translations/th/LC_MESSAGES/messages.po (lines 5238-5240)
@@ -5235,7 +5235,7 @@
# de, es, fa, fr, it, ja, ko, lv, mi, nl, pl, pt, pt_BR, ru, sk, sl, tr,
uk,
# zh, zh_TW]
-#, fuzzy
+#
msgid "Chart could not be restored."
-msgstr ""
+msgstr "ไม่สามารถกู้คืนแผนภูมิได้"
```
</div>
</details>
</div>
<small><i>Code Review Run #1bfcc1</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/cs/LC_MESSAGES/messages.po:
##########
@@ -3106,6 +3106,9 @@ msgstr "Změny grafu"
msgid "Chart could not be created."
msgstr "Graf se nepodařilo vytvořit."
+msgid "Chart could not be restored."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Czech translation</b></div>
<div id="fix">
The Czech translation for "Chart could not be restored." is missing (empty
`msgstr`). Other similar error messages in this file have proper Czech
translations. Without a translation, Czech-speaking users will see the
untranslated English text or an empty string when this error occurs.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- superset/translations/cs/LC_MESSAGES/messages.po (lines 3109-3110) ---
3109: msgid "Chart could not be restored."
3110:-msgstr ""
3110:+msgstr "Graf se nepodařilo obnovit."
```
</div>
</details>
</div>
<small><i>Code Review Run #1bfcc1</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
