bito-code-review[bot] commented on code in PR #40129:
URL: https://github.com/apache/superset/pull/40129#discussion_r3384871807
##########
superset/translations/ar/LC_MESSAGES/messages.po:
##########
@@ -3103,6 +3103,9 @@ msgstr "تغييرات المخطط"
msgid "Chart could not be created."
msgstr "تعذر إنشاء مخطط."
+msgid "Chart could not be restored."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Arabic translation</b></div>
<div id="fix">
The new msgid entry for 'Chart could not be restored.' has an empty msgstr.
Arabic users will see the untranslated English text when this error occurs.
Provide the Arabic translation to complete the localization.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- superset/translations/ar/LC_MESSAGES/messages.po (lines 3106-3107) ---
3106: msgid "Chart could not be restored."
3107: -msgstr ""
3107: +msgstr "تعذر استعادة المخطط."
3108:
3109: msgid "Chart could not be updated."
```
</div>
</details>
</div>
<small><i>Code Review Run #612f1d</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/pl/LC_MESSAGES/messages.po:
##########
@@ -3155,6 +3155,9 @@ msgstr "Zmiany wykresu"
msgid "Chart could not be created."
msgstr "Nie można utworzyć wykresu."
+msgid "Chart could not be restored."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Polish translation</b></div>
<div id="fix">
The new message `msgstr ""` is empty, causing Polish users to see the
untranslated English text. Compare with the consistent pattern: "Chart could
not be created." → "Nie można utworzyć wykresu." and "Chart could not be
updated." → "Nie można zaktualizować wykresu.". The suggested translation
follows the same structure.
</div>
</div>
<small><i>Code Review Run #612f1d</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/tr/LC_MESSAGES/messages.po:
##########
@@ -2874,6 +2874,9 @@ msgstr ""
msgid "Chart could not be created."
msgstr "Grafik oluşturulamadı."
+msgid "Chart could not be restored."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Turkish translation</b></div>
<div id="fix">
The `msgstr` is empty for the source string `"Chart could not be restored."`
used by `ChartRestoreFailedError` in `superset/commands/chart/exceptions.py`.
Turkish users will see the untranslated English error message. Following the
established pattern for similar messages ("Grafik oluşturulamadı." for created,
"Grafik gencellenemedi." for updated), the translation should be "Grafik geri
yüklenemedi.".
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- superset/translations/tr/LC_MESSAGES/messages.po (lines 2877-2879)
+++ superset/translations/tr/LC_MESSAGES/messages.po (lines 2877-2879)
@@ -2875,6 +2875,7 @@
msgid "Chart could not be restored."
-msgstr ""
+msgstr "Grafik geri yüklenemedi."
msgid "Chart could not be updated."
```
</div>
</details>
</div>
<small><i>Code Review Run #612f1d</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/ca/LC_MESSAGES/messages.po:
##########
@@ -3121,6 +3121,9 @@ msgstr "Canvis del gràfic"
msgid "Chart could not be created."
msgstr "El gràfic no s'ha pogut crear."
+msgid "Chart could not be restored."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Catalan translation</b></div>
<div id="fix">
Empty `msgstr` on line 3125 means Catalan users will see no error text when
chart restore fails. Per the pattern from adjacent translations (lines 3122 and
3128), provide the Catalan translation. Without it, `ChartRestoreFailedError`
raises an empty string to users.
</div>
</div>
<small><i>Code Review Run #612f1d</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/mi/LC_MESSAGES/messages.po:
##########
@@ -3063,6 +3063,9 @@ msgstr "Huringa kauwhata"
msgid "Chart could not be created."
msgstr "Kāore i taea te hanga i te kauwhata."
+msgid "Chart could not be restored."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Māori translation</b></div>
<div id="fix">
The new `msgid "Chart could not be restored."` has an empty `msgstr ""`.
This user-facing error message will display untranslated text to Māori-speaking
users. Compare with the similar messages on lines 3064 and 3070, which have
proper Māori translations. Add the appropriate translation to complete the
localization.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- superset/translations/mi/LC_MESSAGES/messages.po (line 3067) ---
3066: msgid "Chart could not be restored."
3067:-msgstr ""
3068:+msgstr "Kāore i taea te whakahoki i te kauwhata."
3069:
3070: msgid "Chart could not be updated."
```
</div>
</details>
</div>
<small><i>Code Review Run #612f1d</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/de/LC_MESSAGES/messages.po:
##########
@@ -3149,6 +3149,9 @@ msgstr "Diagrammänderungen"
msgid "Chart could not be created."
msgstr "Diagramm konnte nicht erstellt werden."
+msgid "Chart could not be restored."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing German translation</b></div>
<div id="fix">
The German translation for the new "Chart could not be restored." message is
empty (`msgstr ""`). Adjacent messages have proper German translations (e.g.,
"Diagramm konnte nicht erstellt werden", "Diagramm konnte nicht aktualisiert
werden"). An empty `msgstr` means the English source text will display to
German users instead of a localized message.
</div>
</div>
<small><i>Code Review Run #612f1d</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/fi/LC_MESSAGES/messages.po:
##########
@@ -5342,6 +5342,9 @@ msgstr "Kaaviota ei voitu luoda."
# de, es, fa, fr, it, ja, ko, lv, mi, nl, pl, pt, pt_BR, ru, sk, sl, tr, uk,
# zh, zh_TW]
#, fuzzy
+msgid "Chart could not be restored."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Finnish translation</b></div>
<div id="fix">
The new translation entry has an empty `msgstr` value. Finnish users will
see the untranslated English message 'Chart could not be restored.' when this
error occurs. Compare with similar entries: 'Chart could not be created.' →
'Kaaviota ei voitu luoda.' and 'Chart could not be updated.' → 'Kaaviota ei
voitu päivittää.' — the new entry should follow this pattern.
</div>
</div>
<small><i>Code Review Run #612f1d</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/zh_TW/LC_MESSAGES/messages.po:
##########
@@ -3030,6 +3030,9 @@ msgstr "圖表變化"
msgid "Chart could not be created."
msgstr "您的圖表無法創建。"
+msgid "Chart could not be restored."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing zh_TW translation</b></div>
<div id="fix">
The new translation entry has an empty `msgstr` value. Traditional Chinese
users will see the untranslated English string 'Chart could not be restored.'
instead of localized text. Compare with adjacent entries: 'Chart could not be
created.' → '您的圖表無法創建。' and 'Chart could not be updated.' → '您的圖表無法更新。'
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- superset/translations/zh_TW/LC_MESSAGES/messages.po
+++ superset/translations/zh_TW/LC_MESSAGES/messages.po
@@ -3031,7 +3031,7 @@
msgstr "您的圖表無法創建。"
msgid "Chart could not be restored."
-msgstr ""
+msgstr "您的圖表無法恢復。"
msgid "Chart could not be updated."
msgstr "您的圖表無法更新。"
```
</div>
</details>
</div>
<small><i>Code Review Run #612f1d</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
