bito-code-review[bot] commented on code in PR #40967:
URL: https://github.com/apache/superset/pull/40967#discussion_r3401685897
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts:
##########
@@ -205,6 +205,7 @@ export function transformSeries(
seriesContexts?: { [key: string]: ForecastSeriesEnum[] };
markerEnabled?: boolean;
markerSize?: number;
+ symbolSizeFn?: (value: (number | string | null)[]) => number;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing unit tests for symbolSizeFn</b></div>
<div id="fix">
The new `symbolSizeFn` parameter lacks unit test coverage in
`transformers.test.ts`. Per BITO.md rule [6262], tests should verify actual
business logic. Add tests to validate the fallback behavior (`symbolSizeFn ??
markerSize`) and confirm the function receives correct data values.
</div>
</div>
<small><i>Code Review Run #b98d61</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/Scatter/controlPanel.test.ts:
##########
@@ -33,7 +45,7 @@ const getControl = (controlName: string) => {
'name' in control &&
control.name === controlName
) {
- return control;
+ return control as unknown as TestControl;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Consolidate duplicate mockControls utility across chart
test files</b></div>
<div id="fix">
The mockControls helper function and timeFormatControl definition are
duplicated across 5 test files (Scatter, Line, Area, SmoothLine, Step).
Consider extracting these into a shared test utility to reduce duplication and
improve maintainability. Line ranges: Scatter (48-81),
Line/Area/SmoothLine/Step (36-69).
</div>
</div>
<small><i>Code Review Run #b98d61</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
