rusackas commented on code in PR #40967:
URL: https://github.com/apache/superset/pull/40967#discussion_r3401944594


##########
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/Scatter/controlPanel.test.ts:
##########
@@ -33,7 +45,7 @@ const getControl = (controlName: string) => {
             'name' in control &&
             control.name === controlName
           ) {
-            return control;
+            return control as unknown as TestControl;

Review Comment:
   Done! Pulled `getControl`/`mockControls` into the shared Timeseries test 
helpers and pointed all five files at it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to