codeant-ai-for-open-source[bot] commented on code in PR #40980:
URL: https://github.com/apache/superset/pull/40980#discussion_r3405435493
##########
tests/unit_tests/daos/test_report_dao.py:
##########
@@ -90,3 +90,40 @@ def test_find_by_extra_metadata_escapes_underscore_wildcard(
assert len(results) == 1
assert results[0].name == "with-underscore"
+
+
+def test_find_by_native_filter_id_returns_matching_reports(
+ session: Session,
+) -> None:
+ extra = json.dumps({"dashboard": {"nativeFilters":
"NATIVE_FILTER-abc123"}})
+ _create_report(session, "match", extra_json=extra)
+ _create_report(session, "no-match", extra_json="{}")
+
+ results =
ReportScheduleDAO.find_by_native_filter_id("NATIVE_FILTER-abc123")
+
+ assert len(results) == 1
+ assert results[0].name == "match"
+
+
+def test_find_by_native_filter_id_escapes_percent_wildcard(
+ session: Session,
+) -> None:
+ _create_report(session, "with-percent", extra_json='{"id":
"FILTER-100%x"}')
+ _create_report(session, "other", extra_json='{"id": "FILTER-100yx"}')
+
+ results = ReportScheduleDAO.find_by_native_filter_id("FILTER-100%x")
+
+ assert len(results) == 1
+ assert results[0].name == "with-percent"
+
+
+def test_find_by_native_filter_id_escapes_underscore_wildcard(
+ session: Session,
+) -> None:
Review Comment:
**Suggestion:** Add a docstring to this new test function to clarify the
underscore wildcard escape behavior it is asserting. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The function is newly added and currently lacks a docstring.
This is a direct violation of the rule for newly added Python functions and
classes.
</details>
[Fix in
Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b780524decc5472a80c666b0510ca767&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
| [Fix in VSCode
Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b780524decc5472a80c666b0510ca767&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/daos/test_report_dao.py
**Line:** 120:122
**Comment:**
*Custom Rule: Add a docstring to this new test function to clarify the
underscore wildcard escape behavior it is asserting.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40980&comment_hash=372428bdd85b11248f7244fc6b54c63636833701aa03535cd94f331bf0757ee6&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40980&comment_hash=372428bdd85b11248f7244fc6b54c63636833701aa03535cd94f331bf0757ee6&reaction=dislike'>👎</a>
##########
tests/unit_tests/daos/test_report_dao.py:
##########
@@ -90,3 +90,40 @@ def test_find_by_extra_metadata_escapes_underscore_wildcard(
assert len(results) == 1
assert results[0].name == "with-underscore"
+
+
+def test_find_by_native_filter_id_returns_matching_reports(
+ session: Session,
+) -> None:
+ extra = json.dumps({"dashboard": {"nativeFilters":
"NATIVE_FILTER-abc123"}})
+ _create_report(session, "match", extra_json=extra)
+ _create_report(session, "no-match", extra_json="{}")
+
+ results =
ReportScheduleDAO.find_by_native_filter_id("NATIVE_FILTER-abc123")
+
+ assert len(results) == 1
+ assert results[0].name == "match"
+
+
+def test_find_by_native_filter_id_escapes_percent_wildcard(
+ session: Session,
+) -> None:
Review Comment:
**Suggestion:** Add a short docstring to this newly added test function so
its wildcard-escaping intent is explicitly documented. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This newly added test function is missing a docstring in the final file
state.
That matches the custom rule requiring new Python functions to be documented
inline.
</details>
[Fix in
Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b4c56a397cd7426a9cffc81f78a782c5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
| [Fix in VSCode
Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b4c56a397cd7426a9cffc81f78a782c5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/daos/test_report_dao.py
**Line:** 108:110
**Comment:**
*Custom Rule: Add a short docstring to this newly added test function
so its wildcard-escaping intent is explicitly documented.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40980&comment_hash=61c9070da3273ba0be9d103928efaddea2b227e30af0ee8fb1be5da1c5e253b8&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40980&comment_hash=61c9070da3273ba0be9d103928efaddea2b227e30af0ee8fb1be5da1c5e253b8&reaction=dislike'>👎</a>
##########
tests/unit_tests/daos/test_report_dao.py:
##########
@@ -90,3 +90,40 @@ def test_find_by_extra_metadata_escapes_underscore_wildcard(
assert len(results) == 1
assert results[0].name == "with-underscore"
+
+
+def test_find_by_native_filter_id_returns_matching_reports(
+ session: Session,
+) -> None:
Review Comment:
**Suggestion:** Add a concise docstring under this new test function
definition to describe the scenario and expected behavior being validated.
[custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is a newly added Python function in the changed section and it has no
docstring.
The custom rule requires newly added functions and classes to include
docstrings, so the suggestion correctly identifies a real violation.
</details>
[Fix in
Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=fb075114d71c488a86172e2d022d804c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
| [Fix in VSCode
Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=fb075114d71c488a86172e2d022d804c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/daos/test_report_dao.py
**Line:** 95:97
**Comment:**
*Custom Rule: Add a concise docstring under this new test function
definition to describe the scenario and expected behavior being validated.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40980&comment_hash=ad03de69b9ce6baf296fcee3bad1940d9bf6176ab6c6a27ff09df14fbbeb0059&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40980&comment_hash=ad03de69b9ce6baf296fcee3bad1940d9bf6176ab6c6a27ff09df14fbbeb0059&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
