bito-code-review[bot] commented on code in PR #40980:
URL: https://github.com/apache/superset/pull/40980#discussion_r3406351771
##########
tests/unit_tests/daos/test_report_dao.py:
##########
@@ -90,3 +90,40 @@ def test_find_by_extra_metadata_escapes_underscore_wildcard(
assert len(results) == 1
assert results[0].name == "with-underscore"
+
+
+def test_find_by_native_filter_id_returns_matching_reports(
+ session: Session,
+) -> None:
+ extra = json.dumps({"dashboard": {"nativeFilters":
"NATIVE_FILTER-abc123"}})
+ _create_report(session, "match", extra_json=extra)
+ _create_report(session, "no-match", extra_json="{}")
+
+ results =
ReportScheduleDAO.find_by_native_filter_id("NATIVE_FILTER-abc123")
+
+ assert len(results) == 1
+ assert results[0].name == "match"
+
+
+def test_find_by_native_filter_id_escapes_percent_wildcard(
+ session: Session,
+) -> None:
+ _create_report(session, "with-percent", extra_json='{"id":
"FILTER-100%x"}')
+ _create_report(session, "other", extra_json='{"id": "FILTER-100yx"}')
+
+ results = ReportScheduleDAO.find_by_native_filter_id("FILTER-100%x")
+
+ assert len(results) == 1
+ assert results[0].name == "with-percent"
+
+
+def test_find_by_native_filter_id_escapes_underscore_wildcard(
+ session: Session,
+) -> None:
+ _create_report(session, "with-underscore", extra_json='{"id":
"FILTER-a_b"}')
+ _create_report(session, "other", extra_json='{"id": "FILTER-axb"}')
+
+ results = ReportScheduleDAO.find_by_native_filter_id("FILTER-a_b")
+
+ assert len(results) == 1
+ assert results[0].name == "with-underscore"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing edge case test</b></div>
<div id="fix">
The test suite for `find_by_native_filter_id` is missing the 'no match
returns empty list' edge case that exists for `find_by_extra_metadata` at line
61-68. This inconsistency could allow bugs where unexpected data triggers false
positives to go undetected.
</div>
</div>
<small><i>Code Review Run #672bd7</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
