bito-code-review[bot] commented on code in PR #40746: URL: https://github.com/apache/superset/pull/40746#discussion_r3406535546
########## tests/unit_tests/mcp_service/user/test_schemas.py: ########## @@ -0,0 +1,124 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""Unit tests for user-related MCP schemas.""" + +from unittest.mock import MagicMock + +import pytest +from pydantic import ValidationError +from sqlalchemy.orm.exc import DetachedInstanceError + +from superset.mcp_service.user.schemas import UserInfo, serialize_user_object Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing import causes NameError</b></div> <div id="fix"> The test file uses `sanitize_for_llm_context` in assertions (lines 87-89, 90-92, 117-119, 120-122) but does not import it. The import on line 26 only brings in `UserInfo` and `serialize_user_object` from `superset.mcp_service.user.schemas`. This causes a `NameError` at runtime when running the tests. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- a/tests/unit_tests/mcp_service/user/test_schemas.py +++ b/tests/unit_tests/mcp_service/user/test_schemas.py @@ -26,1 +26,2 @@ from superset.mcp_service.user.schemas import UserInfo, serialize_user_object +from superset.mcp_service.utils import sanitize_for_llm_context ``` </div> </details> </div> <small><i>Code Review Run #ba8eb6</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## tests/unit_tests/mcp_service/user/test_schemas.py: ########## @@ -0,0 +1,124 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""Unit tests for user-related MCP schemas.""" + +from unittest.mock import MagicMock + +import pytest +from pydantic import ValidationError +from sqlalchemy.orm.exc import DetachedInstanceError + +from superset.mcp_service.user.schemas import UserInfo, serialize_user_object Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Undefined name sanitize_for_llm_context</b></div> <div id="fix"> The function `sanitize_for_llm_context` is referenced but not imported. Add the missing import from `superset.mcp_service.user.schemas`. Similar undefined name issues exist on lines 90, 117, and 120. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ````suggestion from superset.mcp_service.user.schemas import UserInfo, serialize_user_object from superset.mcp_service.user.schemas import sanitize_for_llm_context ```` </div> </details> </div> <small><i>Code Review Run #ba8eb6</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
