rusackas commented on PR #40820: URL: https://github.com/apache/superset/pull/40820#issuecomment-4700716673
@aminghadersohi thanks for the close read! Grabbed the two easy ones - added the `existsSync` 404 guard to match `embedded-dashboard.spec.ts` and dropped the dead `result?.id` branch. The one I actually want to chew on is M3: this started as a TDD red test, so green here either means the fix already landed on `master` or the scroll never trips the remount. I need to confirm which before I trust it as a guard... will dig in. The `waitForTimeout` / `.toggle` points are fair too - I want to swap the sleeps for a real DOM signal once I know the test is exercising the right path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
