rusackas commented on PR #40820: URL: https://github.com/apache/superset/pull/40820#issuecomment-4704569388
@aminghadersohi grabbed M2 and L1 in the latest commit - scoped the toggle to `.pvtTable .toggle` and pinned both `expect.poll` calls to `EMBEDDED.CHART_RENDER`. M1 and M3 are still on me: I want to confirm the test actually goes red on an unpatched build before I swap the `waitForTimeout` sleeps for a real DOM signal, since both hinge on whether the scroll genuinely trips the remount. Digging in next. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
