rusackas commented on PR #40817:
URL: https://github.com/apache/superset/pull/40817#issuecomment-4700913677
@aminghadersohi thanks for the thorough look. Fixed the `||` → `??` so epoch
`0` survives.
The locale one's a fair point - `extendedDayjs` only loads `en`, so
`.locale('fr')` quietly no-ops. I'm a little torn on whether to throw vs just
document it... throwing feels harsh for a template helper. Leaning toward a
comment for now, but curious what you'd prefer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
