rusackas commented on PR #40817: URL: https://github.com/apache/superset/pull/40817#issuecomment-4704595295
@aminghadersohi went with documenting the `en`-only locale behavior right at the call site rather than throwing, since a hard error felt heavy for a template helper. Also added the Jest edge-case tests you suggested (invalid date, non-string format, epoch-0, unloaded locale). Separately, the playwright failure turned out to be a test bug of mine: `HTML_SANITIZATION` strips the `class` attribute, so `li.hb-item` never matched even though the dates rendered fine. Switched the assertion to plain `li`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
