aminghadersohi commented on code in PR #40961:
URL: https://github.com/apache/superset/pull/40961#discussion_r3410550447
##########
superset/mcp_service/dashboard/schemas.py:
##########
@@ -374,6 +374,17 @@ class GetDashboardLayoutRequest(BaseModel):
]
+class GetDashboardDatasetsRequest(BaseModel):
+ """Request schema for get_dashboard_datasets."""
+
+ identifier: Annotated[
+ int | str,
+ Field(
+ description="Dashboard identifier - can be numeric ID, UUID
string, or slug"
+ ),
+ ]
Review Comment:
Intentional — this matches the existing mcp_service convention where each
tool has its own standalone request schema (see GetDashboardInfoRequest /
GetDashboardLayoutRequest). Keeping it separate lets this request evolve
independently (e.g. future limit/filter params) and avoids a premature
abstraction over two short identical classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
