bito-code-review[bot] commented on code in PR #40961:
URL: https://github.com/apache/superset/pull/40961#discussion_r3410550942
##########
superset/mcp_service/dashboard/schemas.py:
##########
@@ -374,6 +374,17 @@ class GetDashboardLayoutRequest(BaseModel):
]
+class GetDashboardDatasetsRequest(BaseModel):
+ """Request schema for get_dashboard_datasets."""
+
+ identifier: Annotated[
+ int | str,
+ Field(
+ description="Dashboard identifier - can be numeric ID, UUID
string, or slug"
+ ),
+ ]
Review Comment:
<!-- Bito Reply -->
The suggestion to extract a shared `DashboardIdentifier` mixin or base class
is a valid architectural recommendation to reduce code duplication. However,
maintaining separate request schemas is also a standard practice in this
service to allow for independent evolution of request parameters. Given that
the current schemas are small and identical, either approach is acceptable; you
may choose to keep them separate for simplicity or refactor them if you
anticipate further shared fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
