codeant-ai-for-open-source[bot] commented on code in PR #40431:
URL: https://github.com/apache/superset/pull/40431#discussion_r3415183695
##########
superset/translations/de/LC_MESSAGES/messages.po:
##########
@@ -2214,16 +2052,14 @@ msgstr "Möchten Sie die ausgewählten Diagramme wirklich
löschen?"
msgid "Are you sure you want to delete the selected dashboards?"
msgstr "Möchten Sie die ausgewählten Dashboards wirklich löschen?"
-#, fuzzy
msgid "Are you sure you want to delete the selected groups?"
-msgstr "Möchten Sie die ausgewählten Ebenen wirklich löschen?"
+msgstr "Möchten Sie die ausgewählten Gruppen wirklich löschen?"
msgid "Are you sure you want to delete the selected layers?"
msgstr "Möchten Sie die ausgewählten Ebenen wirklich löschen?"
-#, fuzzy
msgid "Are you sure you want to delete the selected roles?"
-msgstr "Möchten Sie die ausgewählten Ebenen wirklich löschen?"
+msgstr "Möchten Sie die ausgewählten Rollen wirklich löschen?"
msgid "Are you sure you want to delete the selected rules?"
msgstr "Möchten Sie die ausgewählten Ebenen wirklich löschen?"
Review Comment:
**Suggestion:** This confirmation text is mapped to the wrong entity: it
asks about deleting layers while the source string is about deleting rules.
This can mislead users during destructive actions. Align the translation with
"rules". [logic error]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ⚠️ RLS rule deletion prompt mentions unrelated "layers".
- ⚠️ Users may hesitate or misinterpret what gets deleted.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Set Superset UI language to German and navigate to Row Level Security at
`Security →
Row Level Security` (component
`superset-frontend/src/pages/RowLevelSecurityList/index.tsx`).
2. Select one or more RLS rules in the list and click the bulk delete
action, which opens
`<ConfirmStatusChange>` with description `t('Are you sure you want to delete
the selected
rules?')` at `index.tsx:342`.
3. gettext resolves this msgid via the German catalog entry at
`superset/translations/de/LC_MESSAGES/messages.po:2064-2065`.
4. Observe that the confirmation dialog in German reads `"Möchten Sie die
ausgewählten
Ebenen wirklich löschen?"` ("layers") instead of "Regeln", referring to a
different object
type and potentially confusing users before a destructive action.
```
</details>
[Fix in
Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=e4c8db899a90429ba354a75ac9261343&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
| [Fix in VSCode
Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=e4c8db899a90429ba354a75ac9261343&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/translations/de/LC_MESSAGES/messages.po
**Line:** 2064:2065
**Comment:**
*Logic Error: This confirmation text is mapped to the wrong entity: it
asks about deleting layers while the source string is about deleting rules.
This can mislead users during destructive actions. Align the translation with
"rules".
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40431&comment_hash=3b68fa702198d346ab8dd3d223f3abf2a7f0ee95c54e0c395356f90084fe5589&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40431&comment_hash=3b68fa702198d346ab8dd3d223f3abf2a7f0ee95c54e0c395356f90084fe5589&reaction=dislike'>👎</a>
##########
superset/translations/de/LC_MESSAGES/messages.po:
##########
@@ -3299,37 +3082,34 @@ msgstr "Diagrammtyp auswählen"
msgid "Choose columns to be parsed as dates"
msgstr "Wählen Sie Spalten, die als Datumswerte analysiert werden sollen"
-#, fuzzy
msgid "Choose columns to read"
-msgstr "Zu lesende Spalten"
+msgstr "Zu lesende Spalten wählen"
-msgid ""
-"Choose from existing dashboard filters and select a value to refine your "
-"report results."
+msgid "Choose from existing dashboard filters and select a value to refine
your report results."
msgstr ""
+"Wählen Sie aus den vorhandenen Dashboard-Filtern aus und legen Sie einen Wert
fest, um Ihre "
+"Berichtsergebnisse einzugrenzen."
msgid "Choose how many X-Axis labels to show"
-msgstr ""
+msgstr "Wählen Sie aus, wie viele Beschriftungen auf der x-Achse angezeigt
werden sollen"
msgid "Choose index column"
-msgstr "Index Spalte"
+msgstr "Index Spalte auswählen"
-msgid ""
-"Choose layers to hide from all deck.gl Multiple Layer charts in this "
-"dashboard."
+msgid "Choose layers to hide from all deck.gl Multiple Layer charts in this
dashboard."
msgstr ""
+"Wählen Sie die Ebenen aus, die für alle deck.gl Multilayer-Diagramme in
diesem Dashboard "
+"ausgeblendet werden sollen."
msgid "Choose notification method and recipients."
msgstr "Wählen Sie die Benachrichtigungsmethode und die Empfänger."
-#, fuzzy, python-format
+#, python-format
msgid "Choose numbers between %(min)s and %(max)s"
-msgstr "Die Werte müssen zwischen %(min)s und %(max)s liegen."
+msgstr "Wählen Sie Zahlen zwischen %(min)s und %(max)s"
msgid "Choose one of the available databases from the panel on the left."
-msgstr ""
-"Wählen Sie einen der verfügbaren Datensätze aus dem Bereich auf der "
-"linken Seite."
+msgstr "Wählen Sie einen der verfügbaren Datensätze aus dem Bereich auf der
linken Seite."
Review Comment:
**Suggestion:** This string should instruct users to choose a database, but
the translation says "dataset," which changes the workflow step and can cause
navigation errors. Keep the target term as database. [logic error]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ⚠️ SQL Lab onboarding text references datasets instead of databases.
- ⚠️ German users may search wrong panel to start querying.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Set the UI language to German and open SQL Lab's SQL Editor
(`superset-frontend/src/SqlLab/components/SqlEditor/index.tsx`).
2. Ensure no database is selected for the current tab so the empty-state
prompt is shown;
this prompt uses `t('Choose one of the available databases from the panel on
the left.')`
at `index.tsx:1046`.
3. gettext resolves that msgid via the German catalog entry at
`superset/translations/de/LC_MESSAGES/messages.po:3111-3112`.
4. Observe the German guidance text: `"Wählen Sie einen der verfügbaren
Datensätze aus dem
Bereich auf der linken Seite."`, which tells users to pick a "dataset"
instead of a
"database", misdirecting them from the actual database selector.
```
</details>
[Fix in
Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=79bfdbe96c21461da7183a1c0c0a5204&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
| [Fix in VSCode
Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=79bfdbe96c21461da7183a1c0c0a5204&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/translations/de/LC_MESSAGES/messages.po
**Line:** 3111:3112
**Comment:**
*Logic Error: This string should instruct users to choose a database,
but the translation says "dataset," which changes the workflow step and can
cause navigation errors. Keep the target term as database.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40431&comment_hash=2f19a4d4f569cddceb191cfd91c908f9ab1c27cd06ff33a7eac178c40aff93d1&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40431&comment_hash=2f19a4d4f569cddceb191cfd91c908f9ab1c27cd06ff33a7eac178c40aff93d1&reaction=dislike'>👎</a>
##########
superset/translations/de/LC_MESSAGES/messages.po:
##########
@@ -7443,35 +6892,31 @@ msgid "Has created by"
msgstr "Hat „Erstellt von“"
msgid "Header"
-msgstr "Header"
+msgstr "Überschrift"
msgid "Header row"
msgstr "Kopfzeile"
-#, fuzzy
msgid "Header row is required"
-msgstr "Wert ist erforderlich"
+msgstr "Kopfzeile ist erforderlich"
msgid "Heatmap"
msgstr "Heatmap"
msgid "Height"
msgstr "Höhe"
-#, fuzzy
msgid "Height of each row in pixels"
-msgstr "Die Breite der Isoline in Pixeln"
+msgstr "Die Breite jeder Zeile in Pixeln"
Review Comment:
**Suggestion:** The translation changes "height" to "width", which inverts
the configuration meaning for table row sizing and can cause users to tune the
wrong property. Translate it as row height in pixels. [logic error]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ⚠️ Matrixify row height control text describes width instead.
- ⚠️ German users may tune wrong dimension of row size.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. With German selected as UI language, create or open a Matrixify chart
(Matrixify
controls live in
`superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/matrixifyControls.tsx:303-309`).
2. Open the chart's "Customize / Matrixify" control section; the
`matrixify_row_height`
control uses description `t('Height of each row in pixels')` (also
referenced in
`sections/matrixify.tsx:62`).
3. gettext resolves this msgid using the German translation at
`superset/translations/de/LC_MESSAGES/messages.po:6909-6910`.
4. Observe that the German description shows `"Die Breite jeder Zeile in
Pixeln"` (width
of each row) while the control actually adjusts row height, which can
mislead users about
what the setting does.
```
</details>
[Fix in
Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=91eedc36f8214a36b18a500572544406&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
| [Fix in VSCode
Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=91eedc36f8214a36b18a500572544406&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/translations/de/LC_MESSAGES/messages.po
**Line:** 6909:6910
**Comment:**
*Logic Error: The translation changes "height" to "width", which
inverts the configuration meaning for table row sizing and can cause users to
tune the wrong property. Translate it as row height in pixels.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40431&comment_hash=dbe03d6a31f8e93710c4b65c9560154bba4365d7c899436e0c7a9c1ed6a7473f&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40431&comment_hash=dbe03d6a31f8e93710c4b65c9560154bba4365d7c899436e0c7a9c1ed6a7473f&reaction=dislike'>👎</a>
##########
superset/translations/de/LC_MESSAGES/messages.po:
##########
@@ -9530,46 +8841,39 @@ msgid "No saved metrics found"
msgstr "Keine gespeicherten Metriken gefunden"
msgid "No stored results found, you need to re-run your query"
-msgstr ""
-"Keine gespeicherten Ergebnisse gefunden. Sie müssen Ihre Abfrage erneut "
-"ausführen"
+msgstr "Keine gespeicherten Ergebnisse gefunden. Sie müssen Ihre Abfrage
erneut ausführen"
msgid "No such column found. To filter on a metric, try the Custom SQL tab."
msgstr ""
-"Eine solche Spalte wurde nicht gefunden. Um nach einer Metrik zu filtern,"
-" versuchen Sie es mit der Registerkarte Benutzerdefinierte SQL."
+"Eine solche Spalte wurde nicht gefunden. Um nach einer Metrik zu filtern,
versuchen Sie es mit "
+"der Registerkarte Benutzerdefinierte SQL."
msgid "No table columns"
msgstr "Keine Tabellenspalten"
-#, fuzzy
msgid "No tasks yet"
-msgstr "Noch keine %s"
+msgstr "Noch keine Aufgaben"
msgid "No temporal columns found"
msgstr "Keine Zeitspalten gefunden"
msgid "No time columns"
msgstr "Nicht-Zeitspalten"
Review Comment:
**Suggestion:** The translation for "No time columns" now reads as "non-time
columns," which is the opposite meaning and can mislead users about schema
capabilities. It should state that there are no time columns available. [logic
error]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ⚠️ Time-column picker suggests "non-time columns" exist.
- ⚠️ German users misinterpret missing temporal columns state.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Using German as the UI language, open a filter configuration that uses
the Time Column
filter plugin, e.g., add a time column filter in a dashboard
(`superset-frontend/src/filters/components/TimeColumn/TimeColumnFilterPlugin.tsx`).
2. In `TimeColumnFilterPlugin.tsx:84`, when `timeColumns.length === 0`, the
placeholder
text is set to `t('No time columns')`; the same string is used in chart
customization at
`chartCustomizations/components/TimeColumn/TimeColumnFilterPlugin.tsx:84`.
3. gettext resolves this msgid via the German catalog entry at
`superset/translations/de/LC_MESSAGES/messages.po:8860-8861`.
4. Observe the placeholder `"Nicht-Zeitspalten"` ("non-time columns"), which
implies the
presence of non-time columns instead of correctly stating that there are no
time columns
available, misleading users diagnosing schema capabilities.
```
</details>
[Fix in
Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=cb6e596a93c544a0ab5391e092951ad3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
| [Fix in VSCode
Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=cb6e596a93c544a0ab5391e092951ad3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/translations/de/LC_MESSAGES/messages.po
**Line:** 8860:8861
**Comment:**
*Logic Error: The translation for "No time columns" now reads as
"non-time columns," which is the opposite meaning and can mislead users about
schema capabilities. It should state that there are no time columns available.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40431&comment_hash=8dbc6853a12f4b21e1787c5ccdbd264ef293ada847d44dc2583a5ecd3f51eb35&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40431&comment_hash=8dbc6853a12f4b21e1787c5ccdbd264ef293ada847d44dc2583a5ecd3f51eb35&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
