rusackas opened a new pull request, #41072:
URL: https://github.com/apache/superset/pull/41072

   ### SUMMARY
   
   While cleaning up the dead `TableElement` component (#41071), I ran a 
[knip](https://knip.dev) unused-files scan over `superset-frontend`. After 
filtering out the noise (knip without a config flags ~1,390 build artifacts 
under `packages/*/esm`, `*/lib`, and `storybook-static` — none of which are 
real source), the scan surfaced a small set of genuinely orphaned `src/` 
modules.
   
   Each was independently verified by hand before removal — fixed-string and 
path-based `git grep` across `src/`, `packages/`, `plugins/`, `cypress-base/`, 
and `.storybook/` — confirming **zero references anywhere**: no imports, no 
tests, no stories, no barrel re-exports, not entry points. History shows each 
was orphaned long ago; the recent "last modified" dates are mechanical sweeps 
(the Dec 2025 JS→TS migration, the 2026 core package reorg), not new work 
waiting to be wired up.
   
   Removed:
   
   | File | Added | Notes |
   |---|---|---|
   | `dashboard/components/nativeFilters/ConfigModal/BaseConfigModal.tsx` | 
2025 | no references |
   | `dashboard/util/charts/useAllChartIds.ts` | 2018 | last usage removed in 
#35265 |
   | `dashboard/util/logging/getLoadStatsPerTopLevelComponent.ts` | 2018 | no 
references |
   | `dashboard/util/logging/findTopLevelComponentIds.ts` | 2018 | only used by 
↑ (dead pair) |
   | `dashboard/util/setPeriodicRunner.ts` | 2021 | no references |
   | `features/tags/TagCard.tsx` | 2023 | no references |
   | `hooks/useMemoCompare.ts` | 2023 | no references |
   | `hooks/useOpenerRef.ts` | 2025 | no references |
   | `utils/isDashboardVirtualizationEnabled.ts` | 2024 | no references |
   
   Reviewers: if any of these was intentionally landed ahead of a feature that 
hasn't merged yet, flag it and I'll drop it from the batch — but none show any 
in-flight consumer on `master`.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A — pure dead-code removal, no user-facing change.
   
   ### TESTING INSTRUCTIONS
   
   - `cd superset-frontend && npm run type` — no new errors (the 4 pre-existing 
failures in `AsyncAceEditor`/echarts `tooltip`/pivot-table are present on 
`master` and unrelated).
   - No test/story files reference the removed modules, so no suites change.
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
   - [ ] Introduces new feature or API
   - [x] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to