jesperct commented on PR #41060: URL: https://github.com/apache/superset/pull/41060#issuecomment-4719136817
Thanks for the careful pass. All three are in f0956f7: - Redundant lookups: `_collect_dttm_labels` now does a single `get_column` per label and returns `(label, fmt)` pairs, so `normalize_df` reads the format straight from those instead of resolving it again. Raw labels drop from three lookups to one. - The `not in base_labels` list scan is now a `seen` set, which also dedups a column that appears as both a base-axis label and the granularity. - Added a test for the granularity/columns overlap case. Left `_python_date_format` in place since the legacy `__timestamp` branch still uses it for the granularity column. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
