jesperct commented on PR #41060: URL: https://github.com/apache/superset/pull/41060#issuecomment-4729925071
@aminghadersohi I've pushed fixes for everything from your review in f0956f7: single `get_column` lookup per label, a `seen` set for the dedup, and a test for the granularity/columns overlap. Mind taking another look when you get a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
