michael-s-molina opened a new pull request, #41119: URL: https://github.com/apache/superset/pull/41119
### SUMMARY Clicking the header logo was causing a full page reload instead of a client-side navigation. **Root cause:** The brand logo link used `StyledBrandLink` (based on `Typography.Link`, a plain `<a>` tag), which triggers a full browser navigation. The app was relying on a server-side redirect from `/` → `/superset/welcome/` to resolve the destination, which only works on a hard reload. **Fix:** 1. Replace `StyledBrandLink`'s base component from `Typography.Link` to `GenericLink`, which uses React Router's `<Link>` for internal URLs and a plain `<a>` for external ones — preserving support for custom external `brandLogoHref` values. 2. Add an explicit React Router `<Redirect from="/" to="/superset/welcome/" exact />` to replicate the server-side redirect client-side, so any navigation to `/` (not just from the logo) resolves correctly without a reload. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A ### TESTING INSTRUCTIONS 1. Start the dev server 2. Click the header logo — it should navigate to `/superset/welcome/` without a full page reload 3. Configure a custom `brandLogoHref` with an external URL (e.g. `https://example.com`) — it should still open as a normal link ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
