codeant-ai-for-open-source[bot] commented on code in PR #41120: URL: https://github.com/apache/superset/pull/41120#discussion_r3422621667
########## UPDATING.md: ########## @@ -24,6 +24,15 @@ assists people when migrating to a new version. ## Next +### SQL Lab denies large-object and information_schema access by default + +`DISALLOWED_SQL_FUNCTIONS` and `DISALLOWED_SQL_TABLES` now ship with additional default entries, so SQL Lab and chart-data queries that reference them are rejected where they were previously allowed: + +- PostgreSQL large-object routines (`lo_from_bytea`, `lo_export`, `lo_import`, `lo_put`, `lo_create`, `lowrite`, `lo_get`, `lo_unlink`), which read and write bytes on the database server's filesystem. +- The SQL-standard `information_schema` views (`tables`, `columns`, `routines`, `views`, the privilege/grant views, etc.), which expose table, column, privilege, and view-definition metadata across the whole database. Review Comment: **🟠Architect Review — HIGH** The migration note's list of newly blocked PostgreSQL large-object routines omits `loread`, even though `loread` is included in the `DISALLOWED_SQL_FUNCTIONS["postgresql"]` defaults in `superset/config.py`, so operators relying on the note may miss that this function is now blocked by default. **Suggestion:** Update the large-object routines bullet in UPDATING.md to include `loread`, keeping the documented list in sync with the actual defaults in `DISALLOWED_SQL_FUNCTIONS`. [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=edc06f4b8c7c496e804b7241e6c3f00a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=edc06f4b8c7c496e804b7241e6c3f00a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is an **Architect / Logical Review** comment left during a code review. These reviews are first-class, important findings — not optional suggestions. Do NOT dismiss this as a 'big architectural change' just because the title says architect review; most of these can be resolved with a small, localized fix once the intent is understood. **Path:** UPDATING.md **Line:** 31:32 **Comment:** *HIGH: The migration note's list of newly blocked PostgreSQL large-object routines omits `loread`, even though `loread` is included in the `DISALLOWED_SQL_FUNCTIONS["postgresql"]` defaults in `superset/config.py`, so operators relying on the note may miss that this function is now blocked by default. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. If a suggested approach is provided above, use it as the authoritative instruction. If no explicit code suggestion is given, you MUST still draft and apply your own minimal, localized fix — do not punt back with 'no suggestion provided, review manually'. Keep the change as small as possible: add a guard clause, gate on a loading state, reorder an await, wrap in a conditional, etc. Do not refactor surrounding code or expand scope beyond the finding. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
