sha174n commented on PR #41120: URL: https://github.com/apache/superset/pull/41120#issuecomment-4722561940
@bito-code-review Thanks. The `lo_creat` addition to `DISALLOWED_SQL_FUNCTIONS['postgresql']` is in 22ad47d081. On the estimate-path schema suggestion: the script-level `get_disallowed_tables` already tracks `schema_indeterminate` across statements, so once a `SET search_path` appears it matches unqualified references against the bare-name portion of schema-qualified entries, the denylist is not bypassed on that path. The per-query `search_path` resolution via `get_default_schema_for_query` already runs on the RLS branch of the same command. I've kept the estimate denylist on `get_default_schema` to avoid building a transient probe Query on every estimate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
