rusackas opened a new pull request, #41121:
URL: https://github.com/apache/superset/pull/41121

   ### SUMMARY
   
   Fixes #29622. A report or alert that has **never executed** has `last_state 
= "Not triggered"` (`ReportState.NOOP` is the column default in 
`superset/reports/models.py`). `AlertStatusIcon` rendered that state with a 
green `CheckOutlined` icon and the success color — so an unexecuted report 
looked identical to a successfully-sent one.
   
   This renders the `Not triggered` / unknown state with a neutral 
`CalendarOutlined` icon (per @yousoph's suggestion on the issue) and a neutral 
color instead of the green success styling, and labels it **"Report not yet 
run"** for reports (alerts keep "Nothing triggered", which also covers the 
ran-but-condition-not-met case). `Success` / `Working` / `Error` / `On Grace` 
are unchanged.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before: a never-run report shows a green ✓ (looks like success).
   After: a never-run report shows a neutral calendar icon with the tooltip 
"Report not yet run".
   
   ### TESTING INSTRUCTIONS
   
   Create a new alert/report and don't let it run yet (or check one that hasn't 
run). In the Alerts & Reports list, the "Last Run" status should now show a 
neutral calendar icon, not a green check.
   
   Automated: adds `AlertStatusIcon.test.tsx` covering each state, including a 
regression test that the `Not triggered` state renders the calendar icon and 
**not** the success check icon.
   
   ```
   npm run test -- src/features/alerts/components/AlertStatusIcon.test.tsx
   ```
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue: Fixes #29622
   - [x] Changes UI
   - [ ] Required feature flags:
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to