rusackas commented on code in PR #41121:
URL: https://github.com/apache/superset/pull/41121#discussion_r3438239561
##########
superset-frontend/src/features/alerts/components/AlertStatusIcon.tsx:
##########
@@ -79,8 +84,10 @@ export default function AlertStatusIcon({
lastStateConfig.status = AlertState.Error;
break;
case AlertState.Noop:
- lastStateConfig.icon = Icons.CheckOutlined;
- lastStateConfig.label = t('Nothing triggered');
+ lastStateConfig.icon = Icons.CalendarOutlined;
+ lastStateConfig.label = isReportEnabled
Review Comment:
The filter dropdown is one shared control that can't tell a report from an
alert, so it stays generic (`Not triggered`); the icon tooltip is per-row and
knows the type, which is the whole point of #29622 — a never-run report reading
`Nothing triggered` is what looked wrong. Happy to rename the filter to match
if you think the divergence is more confusing than helpful — preference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
