rusackas commented on PR #36262:
URL: https://github.com/apache/superset/pull/36262#issuecomment-4721948123
Thanks for digging into this @Yogi776! I'm not sure this'll actually do what
we want, though. The value stored in `filter_state` is the whole
`DataMaskStateWithId`, which is a map keyed by filter id rather than an object
with a top-level `id`... so `json.loads(value).get("id")` is going to come back
`None` for any real dashboard. The new tests only pass because the fixture is a
single flat `{"id": ...}` object, which isn't the shape the frontend actually
posts.
And even if we did pull an id out, that's the filter's id, not the
human-readable `name`/label the reporter is after, which lives in the
dashboard's `native_filter_configuration` metadata, not in the cached state.
The thread on #36053 sort of landed on this being a frontend construction thing
too.
Mind taking another look at where `name` is supposed to come from? Happy to
help if you get stuck :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
