betodealmeida commented on code in PR #39340:
URL: https://github.com/apache/superset/pull/39340#discussion_r3423638251
##########
superset/sql/parse.py:
##########
@@ -135,6 +137,29 @@ class CTASMethod(enum.Enum):
VIEW = enum.auto()
+def _normalized_generator(
+ dialect_name: DialectType,
+ *,
+ pretty: bool,
+ comments: bool,
+) -> Generator:
+ """
+ Build a sqlglot generator that preserves user-written multi-argument
Review Comment:
Nit: 1 line description in docstring, for tooling.
```suggestion
Generator that preserves multi-argument DISTINCT expressions.
Build a sqlglot generator that preserves user-written multi-argument
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
