sitelight commented on PR #39340: URL: https://github.com/apache/superset/pull/39340#issuecomment-4734893431
Rebased on current master and addressed review feedback. Force-pushed at `73308659e`. **Changes since approval:** - Rebased onto current `master` (1146 commits since the previous PR HEAD). - Resolved one merge conflict in `sanitize_clause`: kept #39167's `comments=True` (preserve user comments) on top of this PR's `_normalized_generator` refactor. - Adapted `_normalized_generator` to the sqlglot 30 API. In sqlglot 30 `Generator.__slots__` makes `MULTI_ARG_DISTINCT` read-only at the instance level, so the override is now applied via a dynamically-generated subclass with the class attribute set instead of instance assignment. - Added a one-line docstring summary on `_normalized_generator` (@betodealmeida's nit). - Corrected the dialect list in the docstring and the regression-test comment: round-trip verification (`sqlglot 30.11.0`) confirms Dremio's generator does **not** set `MULTI_ARG_DISTINCT=False`, so the original wording overstated the affected dialects. Dremio is kept in the parametrize lists as a defensive regression guard. All 27 new/affected parametrized variants pass locally: ``` pytest tests/unit_tests/sql/parse_tests.py -k "sanitize_clause or sqlstatement_format_preserves_multi_arg_distinct" -v => 27 passed ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
