betodealmeida commented on code in PR #40512: URL: https://github.com/apache/superset/pull/40512#discussion_r3423788410
########## superset/config.py: ########## @@ -196,6 +196,14 @@ def _try_json_readsha(filepath: str, length: int) -> str | None: SUPERSET_DASHBOARD_PERIODICAL_REFRESH_LIMIT = 0 SUPERSET_DASHBOARD_PERIODICAL_REFRESH_WARNING_MESSAGE = None +# Manual dashboard refresh staggers chart data requests across this many +# milliseconds so they do not all hit the backend at the same instant. The +# value behaves like the existing stagger_time dashboard metadata: the +# frontend uses the larger of this value and the dashboard's stagger_time. +# Set this to 0 to keep the older behavior where every chart request fires +# at the same time when the user clicks the Refresh dashboard button. +SUPERSET_DASHBOARD_MANUAL_REFRESH_STAGGER_MS = 5000 Review Comment: ```suggestion SUPERSET_DASHBOARD_MANUAL_REFRESH_STAGGER_MS = 0 ``` Let's set this to zero by default to preserve existing behavior — I know some people use a very short refresh rate for their dashboards and this might break things for them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
