rusackas opened a new pull request, #41132: URL: https://github.com/apache/superset/pull/41132
### SUMMARY Upgrades `@typescript-eslint/no-unused-vars` from `warn` to `error` in `oxlint.json` (with `argsIgnorePattern`/`varsIgnorePattern` of `^_` and `caughtErrors: "none"`), and cleans up the resulting violations across the frontend so CI enforces a no-dead-code baseline. This is a fresh take on #37886, which went stale. Since that PR was opened, the frontend migrated from ESLint to **oxlint** as the primary linter, so the `.eslintrc.js` half of the old change is obsolete and the rule now lives only in `oxlint.json`. Rather than rebase 5 commits across ~4 months of divergence and 73 conflicting files, this regenerates the cleanup against current `master` — which also catches violations introduced since February. **Cleanup philosophy** (proper fixes, not underscore hacks): - Genuinely dead imports, local variables, and destructured props are **removed** (net −46 lines). - Parameters are only `_`-prefixed when their position is dictated by an external or callback signature: event handlers, render props, antd form validators, `forwardRef`, and omit-from-rest destructuring patterns where the binding intentionally strips a field from a `...rest` spread. 54 source files touched across `src/`, `plugins/`, `packages/`, and `.storybook/`. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A — lint/config and dead-code removal only, no UI change. ### TESTING INSTRUCTIONS - `cd superset-frontend && npm run lint` — passes (0 `no-unused-vars` errors). - Affected unit tests pass (modified test files + tests for components with behavioral edits: DatasourceEditor, Dashboard, BigNumberViz, Matrixify, Label, TimezoneSelector, ChartRenderer, SamplesPane, useColDefs). - `npm run type` introduces no new errors. (Two pre-existing `tsc` failures in `tooltip.test.tsx` and `tableRenders.test.tsx` exist on `master` independent of this branch.) ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API Supersedes #37886. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
