rusackas commented on code in PR #41132:
URL: https://github.com/apache/superset/pull/41132#discussion_r3425401060
##########
superset-frontend/src/components/Tag/utils.test.tsx:
##########
@@ -166,7 +166,7 @@ describe('loadTags', () => {
const calls = fetchMock.callHistory.calls();
// Verify all calls include the custom tag filter
- calls.forEach(call => {
+ calls.forEach(_call => {
Review Comment:
Good catch, the loop was asserting `calls[0]` every iteration. Switched it
to use the iterated `call` so each request actually gets checked.
##########
superset-frontend/plugins/legacy-plugin-chart-country-map/src/CountryMap.ts:
##########
@@ -187,9 +186,11 @@ function CountryMap(element: HTMLElement, props:
CountryMapProps) {
region => region.country_id === d.properties.ISO,
);
- hoverPopup.style('display', 'block').html(
- `<div><strong>${getNameOfRegion(d)}</strong><br>${result.length > 0 ?
formatter(result[0].metric) : ''}</div>`,
- );
+ hoverPopup
+ .style('display', 'block')
+ .html(
+ `<div><strong>${getNameOfRegion(d)}</strong><br>${result.length > 0 ?
formatter(result[0].metric) : ''}</div>`,
+ );
Review Comment:
This PR only reflowed that `.html()` call for prettier after dropping an
unused import, the interpolation itself is unchanged from `master`. So the XSS
concern (if real) predates this lint cleanup and would be its own fix, not in
scope here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
