rusackas commented on PR #41021: URL: https://github.com/apache/superset/pull/41021#issuecomment-4725826375
Thanks for continuing to dial this in @abdelghanibelgaid! The 12-region update is overdue, so I appreciate the effort here. A couple of things before this can go in: 1) The notebook cell reads morocco.geojson back out of src/countries/ and just re-validates it, which means the generator can't actually regenerate Morocco from source anymore... it's reading its own output. Could we pull the 12-region boundaries from a maintained upstream URL instead (if there is one somewhere), the way we already do for Latvia, the Philippines, and Vietnam? That keeps the notebook reproducible and, more importantly, gives us a clear source and license for the geometry, which I'd really want on the record for any map data we ship. The license needs to be ASF-compatible, incidentally. For anyone curious: I went looking to see if Natural Earth could give us this directly, and it can't (yet). Their point-of-view/worldview variants only cover admin-0 country outlines, not admin-1 subdivisions, and their admin-1 data is still the pre-2015 16-region split. So sourcing this externally is totally fair... we just want it to be a real upstream source rather than an unmaintained local file with no license/provenance. Last thing: the superset/examples/countries.py change (dropping Western Sahara) is unrelated to the Morocco GeoJSON and feeds a different, deprecated viz. Mind pulling that back out? Removing it would make Western Sahara/EH/ESH rows resolve to "XXX" there, and it's a sensitive enough edit that I'd rather not have it riding along in a boundary-refresh PR. Let's keep this one scoped to the map. Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
