abdelghanibelgaid commented on PR #41021: URL: https://github.com/apache/superset/pull/41021#issuecomment-4744492362
Thanks again, @rusackas. I’ve addressed the three points you raised: * Removed the unrelated `superset/examples/countries.py` change, so the PR is now scoped to the Country Map update only. * Updated the generator notebook so it no longer reads back from `src/countries/morocco.geojson`. It now loads Morocco ADM1 boundaries from an external, commit-pinned raw GitHub URL. * Added validation in the notebook for the expected 12 Morocco region codes (`MA-01` through `MA-12`) before registering `morocco_copy` in `alt_maps`. The PR should now only modify: * `scripts/Country Map GeoJSON Generator.ipynb` * `src/countries/morocco.geojson` I also validated the notebook JSON and GeoJSON locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
