codeant-ai-for-open-source[bot] commented on code in PR #41124:
URL: https://github.com/apache/superset/pull/41124#discussion_r3425508229
##########
tests/unit_tests/views/test_base.py:
##########
@@ -75,6 +75,14 @@ def
test_default_map_renderer_is_exposed_to_frontend_config() -> None:
assert "DEFAULT_MAP_RENDERER" in FRONTEND_CONF_KEYS
+def test_scarf_analytics_is_exposed_to_frontend_config() -> None:
+ # Exposed at runtime so pre-built images can opt out via the
SCARF_ANALYTICS
+ # config/env var (the webpack build-time flag cannot be changed there).
+ from superset.views.base import FRONTEND_CONF_KEYS
+
+ assert "SCARF_ANALYTICS" in FRONTEND_CONF_KEYS
Review Comment:
**Suggestion:** Add a short docstring to this newly added test function to
document its intent, instead of relying only on inline comments. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The new test function has no docstring in the added code, and the custom
rule explicitly requires newly added Python functions and classes to include
docstrings. This is a real rule violation.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=95eb125cfa0546c9a8f055cb9a14e231&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=95eb125cfa0546c9a8f055cb9a14e231&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/views/test_base.py
**Line:** 78:83
**Comment:**
*Custom Rule: Add a short docstring to this newly added test function
to document its intent, instead of relying only on inline comments.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41124&comment_hash=c18cf8d2e4585c4ac2c672058597ad4ebc9e536e3715f5e3bf726fb22507ff45&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41124&comment_hash=c18cf8d2e4585c4ac2c672058597ad4ebc9e536e3715f5e3bf726fb22507ff45&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
