rusackas commented on code in PR #41124:
URL: https://github.com/apache/superset/pull/41124#discussion_r3430368796
##########
tests/unit_tests/views/test_base.py:
##########
@@ -75,6 +75,14 @@ def
test_default_map_renderer_is_exposed_to_frontend_config() -> None:
assert "DEFAULT_MAP_RENDERER" in FRONTEND_CONF_KEYS
+def test_scarf_analytics_is_exposed_to_frontend_config() -> None:
+ # Exposed at runtime so pre-built images can opt out via the
SCARF_ANALYTICS
+ # config/env var (the webpack build-time flag cannot be changed there).
+ from superset.views.base import FRONTEND_CONF_KEYS
+
+ assert "SCARF_ANALYTICS" in FRONTEND_CONF_KEYS
Review Comment:
Good call — added a docstring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
