rusackas commented on code in PR #34880:
URL: https://github.com/apache/superset/pull/34880#discussion_r3425523272
##########
superset/dashboards/api.py:
##########
@@ -1959,6 +1963,9 @@ def import_(self) -> Response:
else None
)
overwrite = request.form.get("overwrite") == "true"
+ overwrite_all = parse_boolean_string(
+ request.form.get("overwrite_all", "true" if overwrite else "false")
+ )
Review Comment:
This one's intentional I think... defaulting `overwrite_all` to the
`overwrite` value is what makes the API actually fix #34879 (otherwise
`overwrite=true` still leaves the charts/datasets stale, which is the exact
bug). The UI checkbox is there to opt out. Resolving this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
