rusackas commented on code in PR #34880:
URL: https://github.com/apache/superset/pull/34880#discussion_r3425523272
##########
superset/dashboards/api.py:
##########
@@ -1959,6 +1963,9 @@ def import_(self) -> Response:
else None
)
overwrite = request.form.get("overwrite") == "true"
+ overwrite_all = parse_boolean_string(
+ request.form.get("overwrite_all", "true" if overwrite else "false")
+ )
Review Comment:
Coming back to this one... I jumped the gun calling it settled. It's a real
question: defaulting `overwrite_all` to the value of `overwrite` on the API
means `overwrite=true` alone cascades into charts/datasets/databases, which is
a behavior change for existing clients (and the CLI/command default it to
`False`, so the entrypoints disagree). I'm leaning toward making it opt-in /
default `False` everywhere and documenting the flag. Reopening so it doesn't
get lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
